Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 24556002: Make VM Expando use identityHashCode instead of object's hashCode. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make VM Expando use identityHashCode instead of object's hashCode. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=27873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M runtime/lib/expando_patch.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/corelib/expando_test.dart View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-09-25 10:39:35 UTC) #1
Florian Schneider
lgtm
7 years, 2 months ago (2013-09-25 10:42:59 UTC) #2
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-09-25 10:47:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698