Issue 24542002: Re-enable VM isolate tests.

Issue 24542002: Re-enable VM isolate tests. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
ricow1, Lasse Reichstein Nielsen, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-enable VM isolate tests. BUG=https://code.google.com/p/dart/issues/detail?id=6890 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=27868

Patch Set 1 #

Total comments: 4

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -20 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 chunk	+0 lines, -3 lines	2 comments	Download
M	runtime/vm/custom_isolate_test.cc	View	5 chunks	+9 lines, -12 lines	2 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Most of the re-write is due to the tests not having the timer available, so ...

7 years, 2 months ago (2013-09-25 09:09:29 UTC) #1

Anders Johnsen

Committed patchset #1 manually as r27868 (presubmit successful).

7 years, 2 months ago (2013-09-25 09:20:51 UTC) #3

Ivan Posva

DBC -ivan https://codereview.chromium.org/24542002/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/24542002/diff/1/runtime/tests/vm/vm.status#newcode63 runtime/tests/vm/vm.status:63: [ $compiler == none ] What about ...

7 years, 2 months ago (2013-09-25 20:23:45 UTC) #4

Anders Johnsen

7 years, 2 months ago (2013-09-26 14:19:33 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/24542002/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/24542002/diff/1/runtime/tests/vm/vm.status#ne...
runtime/tests/vm/vm.status:63: [ $compiler == none ]
On 2013/09/25 20:23:46, Ivan Posva wrote:
> What about this empty section? Shouldn't you remove the comment and the
section
> header too?

Didn't look at the context, cleaned up in followup.

https://codereview.chromium.org/24542002/diff/1/runtime/vm/custom_isolate_tes...
File runtime/vm/custom_isolate_test.cc (left):

https://codereview.chromium.org/24542002/diff/1/runtime/vm/custom_isolate_tes...
runtime/vm/custom_isolate_test.cc:177: EXPECT_VALID(Dart_CompileAll());
On 2013/09/25 20:23:46, Ivan Posva wrote:
> Why did you remove the Dart_CompileAll call?
> 
> We do have these in certain situations to make sure all of the code loaded
into
> the VM is parseable.

I removed it because it complained about the native Logger_PrintString not being
available. How should I go about adding that? I tried adding it to NativeLookup,
but without much success.

Expand Messages | Collapse Messages