Issue 24536005: Recommit "Change two secure networking tests". Add suppression to status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24536005: Recommit "Change two secure networking tests". Add suppression to status file. (Closed)

Created:
7 years, 2 months ago by Bill Hesse

Modified:
7 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Recommit "Change two secure networking tests". Add suppression to status file. BUG=dartbug.com/13609, dartbug.com/12982 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27935

Patch Set 1 #

Patch Set 2 : Change flaky bad_certificate_test to Pass, Timeout. #

Total comments: 2

Patch Set 3 : Fix long line #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -17 lines)			Patch
M	tests/standalone/io/https_bad_certificate_client.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/secure_multiple_client_server_test.dart	View		2 chunks	+3 lines, -10 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

The fixes to the networking test is needed, or else it fails. The timeout on ...

7 years, 2 months ago (2013-09-26 08:19:07 UTC) #1

kasperl

LGTM. https://codereview.chromium.org/24536005/diff/4001/tests/standalone/io/https_bad_certificate_client.dart File tests/standalone/io/https_bad_certificate_client.dart (right): https://codereview.chromium.org/24536005/diff/4001/tests/standalone/io/https_bad_certificate_client.dart#newcode65 tests/standalone/io/https_bad_certificate_client.dart:65: expect(result == 'true'); // The session cache may ...

7 years, 2 months ago (2013-09-26 08:25:39 UTC) #2

Bill Hesse

7 years, 2 months ago (2013-09-26 09:04:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r27935 (presubmit successful).

Expand Messages | Collapse Messages