Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 24527005: Manually enqueue compareTo, hashCode, ==, and toString in the Dart-to-Dart backend to avoid tree sh… (Closed)

Created:
7 years, 2 months ago by kasperl
Modified:
7 years, 2 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Manually enqueue compareTo, hashCode, ==, and toString in the Dart-to-Dart backend to avoid tree shaking these methods out. They may be invoked by the VM core libraries. R=ngeoffray@google.com BUG=http://dartbug.com/11099 Committed: https://code.google.com/p/dart/source/detail?r=27927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A tests/corelib/regress_11099_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
7 years, 2 months ago (2013-09-25 14:01:41 UTC) #1
ngeoffray
LGTM
7 years, 2 months ago (2013-09-25 14:17:30 UTC) #2
kasperl
7 years, 2 months ago (2013-09-26 05:12:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698