Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 24519004: Ensure only a subset of elements enter in Compiler.analyzedElement. (Closed)

Created:
7 years, 2 months ago by ngeoffray
Modified:
7 years, 2 months ago
Reviewers:
karlklose, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure only a subset of elements enter in Compiler.analyzedElement. This was an assumption that most phases had without ensuring them. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=27871

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 1 chunk +9 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
A tests/language/issue13556_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 2 months ago (2013-09-25 08:41:01 UTC) #1
ahe
LGTM!
7 years, 2 months ago (2013-09-25 09:07:11 UTC) #2
ngeoffray
7 years, 2 months ago (2013-09-25 09:56:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698