Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 24509004: Run DOM callbacks in the zone they are coming from. (Closed)

Created:
7 years, 2 months ago by floitsch
Modified:
7 years, 2 months ago
Reviewers:
blois
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

Run DOM callbacks in the zone they are coming from. This CL is an adapted version of: https://chromiumcodereview.appspot.com/23054006/ R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=27961

Patch Set 1 #

Patch Set 2 : Wrap into expectAsync0. #

Total comments: 2

Patch Set 3 : Move code so that test actually tests something. #

Patch Set 4 : DOM callbacks need to be run guarded. #

Patch Set 5 : Run script. #

Patch Set 6 : Reupload due to error #

Patch Set 7 : Reupload. #

Patch Set 8 : Simplify test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -14 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M tests/html/events_test.dart View 1 2 3 4 5 6 7 2 chunks +38 lines, -3 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
floitsch
@Pete: could you please verify that the test completes successfully with Dartium?
7 years, 2 months ago (2013-09-25 14:28:05 UTC) #1
blois
Seeing an error in html/events_test: 5 FAIL Expectation: DOM event callbacks are associated with the ...
7 years, 2 months ago (2013-09-25 16:51:48 UTC) #2
blois
On 2013/09/25 16:51:48, blois wrote: > Seeing an error in html/events_test: > 5 FAIL Expectation: ...
7 years, 2 months ago (2013-09-25 17:57:33 UTC) #3
floitsch
Learned that the test was synchronous... Moved code in the test, to actually make sure ...
7 years, 2 months ago (2013-09-26 14:17:36 UTC) #4
floitsch
PTAL. I patched it into my local Dartium and the test passed.
7 years, 2 months ago (2013-09-26 16:36:36 UTC) #5
blois
lgtm https://codereview.chromium.org/24509004/diff/3001/tests/html/events_test.dart File tests/html/events_test.dart (right): https://codereview.chromium.org/24509004/diff/3001/tests/html/events_test.dart#newcode106 tests/html/events_test.dart:106: sub = provider.forTarget(element).listen(expectAsync1(handler)); can also do: element.on['test'].listen(...)
7 years, 2 months ago (2013-09-26 16:41:27 UTC) #6
floitsch
https://codereview.chromium.org/24509004/diff/3001/tests/html/events_test.dart File tests/html/events_test.dart (right): https://codereview.chromium.org/24509004/diff/3001/tests/html/events_test.dart#newcode106 tests/html/events_test.dart:106: sub = provider.forTarget(element).listen(expectAsync1(handler)); On 2013/09/26 16:41:27, blois wrote: > ...
7 years, 2 months ago (2013-09-26 16:49:46 UTC) #7
floitsch
7 years, 2 months ago (2013-09-26 16:50:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #8 manually as r27961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698