Discard first line of multiline string if only whitespace

Discard first line of multiline string if only whitespace

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27895

[Ivan Posva, 2013-09-25 16:31:50]

LGTM -ip

https://codereview.chromium.org/24493007/diff/1/runtime/vm/scanner.cc
File runtime/vm/scanner.cc (right):

https://codereview.chromium.org/24493007/diff/1/runtime/vm/scanner.cc#newcode432
runtime/vm/scanner.cc:432: ScanLiteralStringChars(is_raw, true);
Can't you pass string_is_multiline_ here? As this true only applies if we are
scanning a multiline string.

Correct would be "string_is_multiline_ ? true : false", but that seems a bit too
over the top.

https://codereview.chromium.org/24493007/diff/1/runtime/vm/scanner.cc#newcode603
runtime/vm/scanner.cc:603: if ((ch != ' ') && (ch != '\t')) {
Please clarify the definition of white-space definition with Gilad.

[hausner, 2013-09-25 17:06:49]

https://codereview.chromium.org/24493007/diff/1/runtime/vm/scanner.cc
File runtime/vm/scanner.cc (right):

https://codereview.chromium.org/24493007/diff/1/runtime/vm/scanner.cc#newcode432
runtime/vm/scanner.cc:432: ScanLiteralStringChars(is_raw, true);
On 2013/09/25 16:31:50, Ivan Posva wrote:
> Can't you pass string_is_multiline_ here? As this true only applies if we are
> scanning a multiline string.
> 
> Correct would be "string_is_multiline_ ? true : false", but that seems a bit
too
> over the top.

Simplified as you suggested.

https://codereview.chromium.org/24493007/diff/1/runtime/vm/scanner.cc#newcode603
runtime/vm/scanner.cc:603: if ((ch != ' ') && (ch != '\t')) {
On 2013/09/25 16:31:50, Ivan Posva wrote:
> Please clarify the definition of white-space definition with Gilad.

Will do. I used the WHITESPACE production in the spec, although this production
is not used to formally define what whitespace means in a string literal.

[hausner, 2013-09-25 17:26:59]

Committed patchset #2 manually as r27895 (presubmit successful).