Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 24492004: Fix https_bad_certificate_test. (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix https_bad_certificate_test. BUG=dartbug.com/13609 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=27957

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix braino. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tests/standalone/io/https_bad_certificate_client.dart View 1 3 chunks +3 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years, 2 months ago (2013-09-26 14:41:42 UTC) #1
Anders Johnsen
lgtm https://codereview.chromium.org/24492004/diff/1/tests/standalone/io/https_bad_certificate_client.dart File tests/standalone/io/https_bad_certificate_client.dart (right): https://codereview.chromium.org/24492004/diff/1/tests/standalone/io/https_bad_certificate_client.dart#newcode45 tests/standalone/io/https_bad_certificate_client.dart:45: request.close().then((result) { }); return request.close(); ? https://codereview.chromium.org/24492004/diff/1/tests/standalone/io/https_bad_certificate_client.dart#newcode67 tests/standalone/io/https_bad_certificate_client.dart:67: ...
7 years, 2 months ago (2013-09-26 14:49:08 UTC) #2
Bill Hesse
https://codereview.chromium.org/24492004/diff/1/tests/standalone/io/https_bad_certificate_client.dart File tests/standalone/io/https_bad_certificate_client.dart (right): https://codereview.chromium.org/24492004/diff/1/tests/standalone/io/https_bad_certificate_client.dart#newcode45 tests/standalone/io/https_bad_certificate_client.dart:45: request.close().then((result) { }); On 2013/09/26 14:49:08, Anders Johnsen wrote: ...
7 years, 2 months ago (2013-09-26 15:11:07 UTC) #3
Bill Hesse
7 years, 2 months ago (2013-09-26 15:12:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698