Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 24487003: Don't test writing 1 byte 65k times. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't test writing 1 byte 65k times. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M tests/standalone/io/process_sync_test.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
This was timing out on Windows, and since we then kill the parent process, the ...
7 years, 3 months ago (2013-09-25 08:29:44 UTC) #1
Søren Gjesse
LGTM We should add this back when we fix the performance issue.
7 years, 3 months ago (2013-09-25 08:34:50 UTC) #2
Anders Johnsen
7 years, 3 months ago (2013-09-25 09:10:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698