Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 24481002: New analyzer_experimental snapshot. (Closed)

Created:
7 years, 3 months ago by scheglov
Modified:
7 years, 2 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer_experimental snapshot. There are couple small changes in analyzer itself: 1. AnalysisCache.entrySet() to return Collection instead of Set - it is expensive to fill actual Set in Dart - hash code, equals, etc. We know there are no duplicates. 2. Matcher in TODO scrapper - there are no start(i) in Dart, I have to change implementation to translate it accurately. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5482 lines, -5991 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/ImportDirective.java View 2 chunks +2 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/TodoCode.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/cache/AnalysisCache.java View 2 chunks +5 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java View 1 chunk +5 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/EngineTestCase.java View 2 chunks +17 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/error/TodoCodeTest.java View 2 chunks +6 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/cache/AnalysisCacheTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 2 chunks +22 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 2 chunks +6 lines, -36 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 5 chunks +26 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java View 1 chunk +4 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java View 3 chunks +24 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java View 3 chunks +20 lines, -8 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/CollectionSemanticProcessorTest.java View 1 chunk +26 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 2 chunks +62 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/PropertySemanticProcessorTest.java View 1 chunk +34 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 32 chunks +211 lines, -102 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/constant.dart View 6 chunks +36 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 42 chunks +153 lines, -128 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 74 chunks +1576 lines, -3782 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 73 chunks +264 lines, -132 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/instrumentation.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 2 chunks +22 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 16 chunks +161 lines, -91 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 95 chunks +687 lines, -248 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/scanner.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk_io.dart View 4 chunks +5 lines, -9 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source.dart View 3 chunks +21 lines, -14 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source_io.dart View 5 chunks +36 lines, -9 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/ast_test.dart View 8 chunks +26 lines, -25 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/element_test.dart View 12 chunks +91 lines, -91 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 12 chunks +37 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 571 chunks +1793 lines, -1153 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/scanner_test.dart View 4 chunks +13 lines, -88 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/test_support.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/test/services/test_utils.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 3 chunks +43 lines, -22 lines 0 comments Download
M tests/co19/co19-co19.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 4 chunks +11 lines, -10 lines 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 3 months ago (2013-09-25 00:03:47 UTC) #1
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-09-25 13:12:11 UTC) #2
scheglov
7 years, 2 months ago (2013-09-25 16:02:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27889 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698