Migrate dartium_tools from chrome branch to dart repo

Migrate dartium_tools from chrome branch to dart repo

Copy file from
svn://svn.chromium.org/chrome/branches/dart/1847/src/dartium_tools@264987
over to tools/dartium.

Terry: I'll cherry pick your update script from 1908 in a second CL.

R=whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35694

[ricow1, 2014-04-22 16:17:53]

I am not sure all the paths are correct, did you test that they are?

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/arc...
File tools/dartium/archive.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/arc...
tools/dartium/archive.py:43: versionInfo =
utils.getCommandOutput(os.path.join('..', '..',
I that correct? what is this relative to?

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/arc...
tools/dartium/archive.py:181: srcpath = os.path.join(fullpath, '..')
I don't think this is correct

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/bui...
File tools/dartium/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/bui...
tools/dartium/buildbot_annotated_steps.py:40: SRC_PATH =
os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
isn't this getting you src/dart?

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/exp...
File tools/dartium/export_overrides.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/exp...
tools/dartium/export_overrides.py:6: # dartium.deps/DEPS.
can we remove this?

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/gen...
File tools/dartium/generate_dart_vm_version.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/gen...
tools/dartium/generate_dart_vm_version.py:8: utils = imp.load_source('utils',
'src/dart/tools/utils.py')
you should load it relative to this path, i.e., ../utils

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/gen...
tools/dartium/generate_dart_vm_version.py:31: updateFile(EXPIRATION_FILE,
"%dLL\n" % time.mktime(expiration_date.timetuple()))
long line

[Bill Hesse, 2014-04-24 07:50:19]

FYI: I would like to use the archiving scripts on the multivm builder, which
does not include a Dart checkout.  I have checked out dart/tools/bots, and I can
add dart/tools/dartium, but I will also want to make the dartium archiver work
in the case there is no src/dart checkout.

So I will use these scripts from the new location, once the cl is committed.

[vsm, 2014-04-24 17:13:12]

PTAL

I've tested this in a dartium enlistment with dartium_tools (mostly) removed:
- I moved supplement.gypi back to dartium_tools.  The chromium gyp only picks up
'*/supplement.gypi', so it wasn't pulling it from this new location.
- All other files are moved or deleted.
- I tested build.py and archive.py locally.

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/arc...
File tools/dartium/archive.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/arc...
tools/dartium/archive.py:43: versionInfo =
utils.getCommandOutput(os.path.join('..', '..',
On 2014/04/22 16:17:53, ricow1 wrote:
> I that correct? what is this relative to?

Yes.  It's relative to the build directory (e.g., 'out/Release').

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/arc...
tools/dartium/archive.py:181: srcpath = os.path.join(fullpath, '..')
On 2014/04/22 16:17:53, ricow1 wrote:
> I don't think this is correct

Done.

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/bui...
File tools/dartium/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/bui...
tools/dartium/buildbot_annotated_steps.py:40: SRC_PATH =
os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
On 2014/04/22 16:17:53, ricow1 wrote:
> isn't this getting you src/dart?

Thanks, fixed.

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/exp...
File tools/dartium/export_overrides.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/exp...
tools/dartium/export_overrides.py:6: # dartium.deps/DEPS.
On 2014/04/22 16:17:53, ricow1 wrote:
> can we remove this?

Done.

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/gen...
File tools/dartium/generate_dart_vm_version.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/gen...
tools/dartium/generate_dart_vm_version.py:8: utils = imp.load_source('utils',
'src/dart/tools/utils.py')
On 2014/04/22 16:17:53, ricow1 wrote:
> you should load it relative to this path, i.e., ../utils

I'm loading it relative now.  Let me know if there is a better pattern for this.
 I couldn't find one.

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/gen...
tools/dartium/generate_dart_vm_version.py:31: updateFile(EXPIRATION_FILE,
"%dLL\n" % time.mktime(expiration_date.timetuple()))
On 2014/04/22 16:17:53, ricow1 wrote:
> long line

Done.

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/gen...
tools/dartium/generate_dart_vm_version.py:31: updateFile(EXPIRATION_FILE,
"%dLL\n" % time.mktime(expiration_date.timetuple()))
On 2014/04/22 16:17:53, ricow1 wrote:
> long line

Done.

[Bill Hesse, 2014-05-01 15:12:00]

LGTM.

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/bui...
File tools/dartium/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/bui...
tools/dartium/buildbot_annotated_steps.py:43: BUILD_UTIL_PATH =
os.path.join(SRC_PATH, 'build/util')
join(SRC_PATH, 'build', 'util')

https://chromiumcodereview.appspot.com/244643006/diff/60001/tools/dartium/fet...
File tools/dartium/fetch_reference_build.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/60001/tools/dartium/fet...
tools/dartium/fetch_reference_build.py:14: $
./src/dart/tools/dartium/fetch_reference_build_revision.py
Is this CL leaving the existing copies in tools/bots?

If so, then a later CL on the buildbot needs to change
build/scripts/slave/recipes/dart/dartium_perf.py to change the
location of the script, and then the multivm checkout of dart/tools/bots
can be replaced by a checkout of dart/tools/dartium.

Then the copies in tools/bots can be removed.

[vsm, 2014-05-02 16:25:50]

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/bui...
File tools/dartium/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/40001/tools/dartium/bui...
tools/dartium/buildbot_annotated_steps.py:43: BUILD_UTIL_PATH =
os.path.join(SRC_PATH, 'build/util')
On 2014/05/01 15:12:00, Bill Hesse wrote:
> join(SRC_PATH, 'build', 'util')

Done.

https://chromiumcodereview.appspot.com/244643006/diff/60001/tools/dartium/fet...
File tools/dartium/fetch_reference_build.py (right):

https://chromiumcodereview.appspot.com/244643006/diff/60001/tools/dartium/fet...
tools/dartium/fetch_reference_build.py:14: $
./src/dart/tools/dartium/fetch_reference_build_revision.py
Yes, I'm not touching the files under bots.  We can also delete these in the
dartium directory in favor of the ones in bots.  Your call.

On 2014/05/01 15:12:01, Bill Hesse wrote:
> Is this CL leaving the existing copies in tools/bots?
> 
> If so, then a later CL on the buildbot needs to change
> build/scripts/slave/recipes/dart/dartium_perf.py to change the
> location of the script, and then the multivm checkout of dart/tools/bots
> can be replaced by a checkout of dart/tools/dartium.
> 
> Then the copies in tools/bots can be removed.

[vsm, 2014-05-02 16:30:50]

Committed patchset #5 manually as r35694 (presubmit successful).