Issue 24460004: Fix a barback bug where a result could be emitted incorrectly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24460004: Fix a barback bug where a result could be emitted incorrectly. (Closed)

Created:
7 years, 2 months ago by nweiz

Modified:
7 years, 2 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a barback bug where a result could be emitted incorrectly. PackageGraph was relying on its own knowledge of which AssetCascades were dirty, based on which cascades had assets updated. However, it's possible for a cascade to become dirty due to another cascade's asset being updated, and that case was missed. This change addresses that. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27904

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -3 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View	4 chunks	+17 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/package_graph.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/barback/test/package_graph/transform_test.dart	View	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

7 years, 2 months ago (2013-09-25 19:17:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27904 (presubmit successful).

Expand Messages | Collapse Messages