Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 24457003: Wait for the pause-event to have finished. (Closed)

Created:
7 years, 2 months ago by floitsch
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Wait for the pause-event to have finished. BUG= http://dartbug.com/13608 R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=27943

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tests/lib/async/stream_controller_async_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
7 years, 2 months ago (2013-09-26 09:45:45 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/24457003/diff/1/tests/lib/async/stream_controller_async_test.dart File tests/lib/async/stream_controller_async_test.dart (right): https://codereview.chromium.org/24457003/diff/1/tests/lib/async/stream_controller_async_test.dart#newcode662 tests/lib/async/stream_controller_async_test.dart:662: if (asBroadcast || broadcast) { Ack, yes. The ...
7 years, 2 months ago (2013-09-26 11:58:32 UTC) #2
floitsch
7 years, 2 months ago (2013-09-26 12:12:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27943 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698