Issue 24427003: Removed HttpRequestProgressEvent

Issue 24427003: Removed HttpRequestProgressEvent (Closed)

Created:
7 years, 2 months ago by Emily Fortuna

Modified:
7 years, 2 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removed HttpRequestProgressEvent Turns out position and totalSize were on Firefox 3 and earlier, but we don't have to worry about backwards compatibility that far. https://developer.mozilla.org/es/docs/XMLHttpRequest/Usar_XMLHttpRequest BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=27900

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -84 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+12 lines, -26 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+15 lines, -29 lines	0 comments	Download
M	tests/html/event_test.dart	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/html/html.status	View	1	3 chunks	+0 lines, -3 lines	0 comments	Download
M	tests/html/xhr_test.dart	View	1	2 chunks	+0 lines, -15 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Original bug is at https://code.google.com/p/dart/issues/detail?id=5373

7 years, 2 months ago (2013-09-24 23:57:37 UTC) #1

blois

https://codereview.chromium.org/24427003/diff/7001/tools/dom/idl/dart/dart.idl File tools/dom/idl/dart/dart.idl (right): https://codereview.chromium.org/24427003/diff/7001/tools/dom/idl/dart/dart.idl#newcode308 tools/dom/idl/dart/dart.idl:308: [Suppressed] This should just be an entry in htmlrenamer's ...

7 years, 2 months ago (2013-09-25 00:16:22 UTC) #2

blois

lgtm https://codereview.chromium.org/24427003/diff/7001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/24427003/diff/7001/sdk/lib/html/dart2js/html_dart2js.dart#oldcode13453 sdk/lib/html/dart2js/html_dart2js.dart:13453: -@DomName('XMLHttpRequestProgressEvent') Forgot to re-gen these?

7 years, 2 months ago (2013-09-25 00:40:22 UTC) #4

Emily Fortuna

https://codereview.chromium.org/24427003/diff/7001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/24427003/diff/7001/sdk/lib/html/dart2js/html_dart2js.dart#oldcode13453 sdk/lib/html/dart2js/html_dart2js.dart:13453: -@DomName('XMLHttpRequestProgressEvent') On 2013/09/25 00:40:22, blois wrote: > Forgot to ...

7 years, 2 months ago (2013-09-25 18:01:09 UTC) #5

Emily Fortuna

7 years, 2 months ago (2013-09-25 18:03:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r27900 (presubmit successful).

Expand Messages | Collapse Messages