Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 24397002: Support mixin application typedef as mixin in the VM (issues 9383, 12773). (Closed)

Created:
7 years, 3 months ago by regis
Modified:
7 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Support mixin application typedef as mixin in the VM (issues 9383, 12773). Disallow Object as mixin (issue 10952). Detect illegal cycles in mixins. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=27791

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -153 lines) Patch
M runtime/vm/class_finalizer.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 1 20 chunks +333 lines, -120 lines 0 comments Download
M runtime/vm/object.cc View 1 3 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tests/language/language_dart2js.status View 1 3 chunks +2 lines, -6 lines 0 comments Download
A tests/language/mixin_mixin6_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A tests/language/mixin_mixin7_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 3 months ago (2013-09-23 20:37:49 UTC) #1
hausner
LGTM with comments. https://codereview.chromium.org/24397002/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/24397002/diff/1/runtime/vm/class_finalizer.cc#newcode1479 runtime/vm/class_finalizer.cc:1479: // The super type of this ...
7 years, 3 months ago (2013-09-24 00:15:35 UTC) #2
regis
Thanks! https://codereview.chromium.org/24397002/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/24397002/diff/1/runtime/vm/class_finalizer.cc#newcode1479 runtime/vm/class_finalizer.cc:1479: // The super type of this mixin application ...
7 years, 3 months ago (2013-09-24 00:23:41 UTC) #3
regis
7 years, 3 months ago (2013-09-24 00:25:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698