Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 24395013: Merge services into a shared IOService in dart:io, and use a native port. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Merge services into a shared IOService in dart:io, and use a native port. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27883

Patch Set 1 #

Patch Set 2 : Update file requests. #

Patch Set 3 : Fix fileentity too #

Patch Set 4 : Finish off native_service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+601 lines, -932 lines) Patch
M runtime/bin/builtin_impl_sources.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/builtin_natives.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/bin/directory.h View 1 2 3 2 chunks +9 lines, -4 lines 0 comments Download
M runtime/bin/directory.cc View 1 2 3 11 chunks +35 lines, -103 lines 0 comments Download
M runtime/bin/directory_patch.dart View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/file.h View 1 2 3 3 chunks +26 lines, -4 lines 0 comments Download
M runtime/bin/file.cc View 1 2 3 29 chunks +126 lines, -244 lines 0 comments Download
M runtime/bin/file_patch.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/io_impl_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 2 3 3 chunks +1 line, -2 lines 0 comments Download
A runtime/bin/io_service.h View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
A runtime/bin/io_service.cc View 1 2 3 1 chunk +78 lines, -0 lines 0 comments Download
A runtime/bin/io_service_patch.dart View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download
M runtime/bin/io_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
D runtime/bin/native_service.h View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D runtime/bin/native_service.cc View 1 2 3 1 chunk +0 lines, -46 lines 0 comments Download
M runtime/bin/secure_socket.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/bin/secure_socket.cc View 1 2 3 3 chunks +11 lines, -36 lines 0 comments Download
M runtime/bin/secure_socket_patch.dart View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/bin/socket.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/bin/socket.cc View 1 4 chunks +14 lines, -78 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 6 chunks +3 lines, -18 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 2 3 10 chunks +49 lines, -80 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 25 chunks +31 lines, -155 lines 0 comments Download
M sdk/lib/io/file_system_entity.dart View 1 2 4 chunks +12 lines, -33 lines 0 comments Download
M sdk/lib/io/link.dart View 1 2 3 6 chunks +18 lines, -42 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 1 2 3 2 chunks +9 lines, -11 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
Please go ahead with this change. However as long as there is not thread pool ...
7 years, 3 months ago (2013-09-25 08:49:03 UTC) #1
Anders Johnsen
PTAL, done porting all the services. There is now only 32 shared ports.
7 years, 2 months ago (2013-09-25 14:02:14 UTC) #2
Søren Gjesse
LGTM, nice cleanup
7 years, 2 months ago (2013-09-25 14:55:53 UTC) #3
Anders Johnsen
7 years, 2 months ago (2013-09-25 15:03:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r27883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698