Improve NoSuchMethodError error messages

Improve NoSuchMethodError error messages

- Don't say there is no constructor with name X if there is one
  that has incompatible parameter list.
- Better error message when mismatched optional parameters are passed.
  (Prviously only the number of parameters was considered, but not
  names of named parameters for example.)

Fixes issue 6189.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27826

[regis, 2013-09-24 01:10:23]

LGTM

https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h#newcode1421
runtime/vm/object.h:1421: RawString* UserVisibleParameterSignature() const;
How about UserVisibleFormalParameters?

https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h#newcode1870
runtime/vm/object.h:1870: void ParameterSignatureHelper(
The term ParameterSignature could mean other things.
How about BuildFormalParameters?

https://codereview.chromium.org/24395007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/24395007/diff/1/runtime/vm/parser.cc#newcode7671
runtime/vm/parser.cc:7671: NULL);
As we add a comment for the 4th null argument, you could add:
// No existing function.

[hausner, 2013-09-24 16:15:23]

Committed patchset #2 manually as r27826 (presubmit successful).

[hausner, 2013-09-24 16:17:09]

Thank you.

https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h#newcode1421
runtime/vm/object.h:1421: RawString* UserVisibleParameterSignature() const;
On 2013/09/24 01:10:24, regis wrote:
> How about UserVisibleFormalParameters?

Much better. Done.

https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h#newcode1870
runtime/vm/object.h:1870: void ParameterSignatureHelper(
On 2013/09/24 01:10:24, regis wrote:
> The term ParameterSignature could mean other things.
> How about BuildFormalParameters?

How about BuildSinatureParameters (the parameter portion of BuildSignature)?

https://codereview.chromium.org/24395007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/24395007/diff/1/runtime/vm/parser.cc#newcode7671
runtime/vm/parser.cc:7671: NULL);
On 2013/09/24 01:10:24, regis wrote:
> As we add a comment for the 4th null argument, you could add:
> // No existing function.

Done.

[regis, 2013-09-24 16:22:35]

On 2013/09/24 16:17:09, hausner wrote:
> Thank you.
> 
> https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h
> File runtime/vm/object.h (right):
> 
>
https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h#newcode1421
> runtime/vm/object.h:1421: RawString* UserVisibleParameterSignature() const;
> On 2013/09/24 01:10:24, regis wrote:
> > How about UserVisibleFormalParameters?
> 
> Much better. Done.
> 
>
https://codereview.chromium.org/24395007/diff/1/runtime/vm/object.h#newcode1870
> runtime/vm/object.h:1870: void ParameterSignatureHelper(
> On 2013/09/24 01:10:24, regis wrote:
> > The term ParameterSignature could mean other things.
> > How about BuildFormalParameters?
> 
> How about BuildSinatureParameters (the parameter portion of BuildSignature)?
> 
Great, But with a g in sinature would be even better.


> https://codereview.chromium.org/24395007/diff/1/runtime/vm/parser.cc
> File runtime/vm/parser.cc (right):
> 
>
https://codereview.chromium.org/24395007/diff/1/runtime/vm/parser.cc#newcode7671
> runtime/vm/parser.cc:7671: NULL);
> On 2013/09/24 01:10:24, regis wrote:
> > As we add a comment for the 4th null argument, you could add:
> > // No existing function.
> 
> Done.