Issue 24376005: - Added Dart_GetNativeIsolateData so that the bindings code can access the IsolateCurrentData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24376005: - Added Dart_GetNativeIsolateData so that the bindings code can access the IsolateCurrentData (Closed)

Created:
7 years, 3 months ago by siva

Modified:
7 years, 3 months ago

Reviewers:
vsm, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Added Dart_GetNativeIsolateData so that the bindings code can access the IsolateCurrentData where possible without having to invoke Isolate::Current() - Modified lookupWrapper to accept DartDOMData as a parameter so that the return to Dart functions won't invoke Isolate::Current() Some Dromaeo numbers before this change: CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1162.2 CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1255.6 after this change: CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1237.6 CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1385.4 R=rmacnak@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27789

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -7 lines)			Patch
M	runtime/include/dart_api.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/zone.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

7 years, 3 months ago (2013-09-23 23:53:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r27789 (presubmit successful).

Expand Messages | Collapse Messages