Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 24376004: If the element or selector is a setter, make sure to use the runtime setter name to know whether we… (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

If the element or selector is a setter, make sure to use the runtime setter name to know whether we need to emit the reflection name. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=27842

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-23 20:23:38 UTC) #1
ngeoffray
PTAL
7 years, 3 months ago (2013-09-24 16:01:21 UTC) #2
ahe
LGTM!
7 years, 3 months ago (2013-09-24 17:20:31 UTC) #3
ngeoffray
7 years, 3 months ago (2013-09-24 19:39:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698