Issue 24371003: Formatter selection preservation support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24371003: Formatter selection preservation support. (Closed)

Created:
7 years, 3 months ago by pquitslund

Modified:
7 years, 3 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Formatter selection preservation support. As a first cut, this attempts to preserve starting offsets after formatting. Still todo is some reparing of selection length. Also note: that the JSON format may well change. This is just enough to wire it through the Editor UI (next up). R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=27859

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -11 lines)			Patch
M	pkg/analyzer_experimental/bin/formatter.dart	View	1	6 chunks	+46 lines, -3 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/services/formatter_impl.dart	View	1 2	5 chunks	+25 lines, -3 lines	0 comments	Download
M	pkg/analyzer_experimental/test/services/formatter_test.dart	View	1 2	3 chunks	+23 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pquitslund

7 years, 3 months ago (2013-09-24 22:57:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r27859 (presubmit successful).

Expand Messages | Collapse Messages