Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 24364002: Fix Linux perf profiling support. (Closed)

Created:
7 years, 3 months ago by Florian Schneider
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Fix Linux perf profiling support. This was broken after r27726 because Isolate::Current() is NULL when the PerfCodeObserver is initialized. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=27760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/os_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 3 months ago (2013-09-23 13:15:59 UTC) #1
Kevin Millikin (Google)
lgtm
7 years, 3 months ago (2013-09-23 13:17:18 UTC) #2
Florian Schneider
7 years, 3 months ago (2013-09-23 13:17:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698