Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Issue 243633005: pkg/docgen: fixed some references within typedef doc comments (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/docgen: fixed some references within typedef doc comments R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=35191

Patch Set 1 #

Total comments: 2

Patch Set 2 : cl nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/docgen/lib/src/models/typedef.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/test/typedef_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kevmoo
Validated tests and output of SDK -- much better handling of typedefs. Not perfect, but ...
6 years, 8 months ago (2014-04-18 22:46:43 UTC) #1
Siggi Cherem (dart-lang)
lgtm (but I'm not familiar with this codebase, though) https://codereview.chromium.org/243633005/diff/1/pkg/docgen/lib/src/models/typedef.dart File pkg/docgen/lib/src/models/typedef.dart (right): https://codereview.chromium.org/243633005/diff/1/pkg/docgen/lib/src/models/typedef.dart#newcode65 pkg/docgen/lib/src/models/typedef.dart:65: ...
6 years, 8 months ago (2014-04-18 23:27:55 UTC) #2
kevmoo
https://codereview.chromium.org/243633005/diff/1/pkg/docgen/lib/src/models/typedef.dart File pkg/docgen/lib/src/models/typedef.dart (right): https://codereview.chromium.org/243633005/diff/1/pkg/docgen/lib/src/models/typedef.dart#newcode65 pkg/docgen/lib/src/models/typedef.dart:65: var node = owner.fixReference(name); On 2014/04/18 23:27:55, Siggi Cherem ...
6 years, 8 months ago (2014-04-18 23:46:25 UTC) #3
kevmoo
Committed patchset #2 manually as r35191 (presubmit successful).
6 years, 8 months ago (2014-04-18 23:46:42 UTC) #4
Emily Fortuna
6 years, 8 months ago (2014-04-21 16:36:18 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698