Issue 243583008: Undo r35207

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243583008: Undo r35207 (Closed)

Created:
6 years, 8 months ago by Cutch

Modified:
6 years, 8 months ago

Reviewers:
turnidge, srdjan

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -236 lines)			Patch
M	runtime/bin/vmservice/client/lib/src/elements/function_view.html	View	4 chunks	+10 lines, -20 lines	0 comments	Download
D	runtime/bin/vmservice/client/lib/src/elements/log_view.dart	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	runtime/bin/vmservice/client/lib/src/elements/log_view.html	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/service/object.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/compiler.cc	View	4 chunks	+2 lines, -9 lines	0 comments	Download
M	runtime/vm/deopt_instructions.cc	View	3 chunks	+2 lines, -13 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+2 lines, -11 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/trace_buffer.h	View	3 chunks	+4 lines, -15 lines	0 comments	Download
M	runtime/vm/trace_buffer.cc	View	6 chunks	+12 lines, -49 lines	0 comments	Download
M	runtime/vm/trace_buffer_test.cc	View	4 chunks	+19 lines, -29 lines	0 comments	Download

Total messages: 3 (0 generated)

Cutch

Committed patchset #1 manually as r35208 (presubmit successful).

6 years, 8 months ago (2014-04-21 16:04:00 UTC) #2

Message was sent while issue was closed.

lgtm