Issue 2434903002: Fix crash generating facades for loasd. Fix bug in how we handle TypePredicates. Add test for TypeP…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2434903002: Fix crash generating facades for loasd. Fix bug in how we handle TypePredicates. Add test for TypeP… (Closed)

Created:
4 years, 2 months ago by Jacob

Modified:
4 years, 2 months ago

Reviewers:
matanl, kevmoo

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix crash generating facades for loasd. Fix bug in how we handle TypePredicates. Add test for TypePredicates case. BUG= R=matanl@google.com Committed: https://github.com/dart-lang/js_facade_gen/commit/f8a47791e182ce7e4715ec8c028f4772860003f0

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -9 lines)			Patch
M	lib/base.ts	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	lib/declaration.ts	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/facade_converter.ts	View		3 chunks	+9 lines, -2 lines	0 comments	Download
M	lib/merge.ts	View		4 chunks	+5 lines, -4 lines	0 comments	Download
M	package.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/function_test.ts	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Jacob

This fixes https://github.com/dart-lang/js_facade_gen/issues/15

4 years, 2 months ago (2016-10-19 20:45:06 UTC) #2

Jacob

4 years, 2 months ago (2016-10-19 21:06:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f8a47791e182ce7e4715ec8c028f4772860003f0 (presubmit successful).