Add a toString() to LogRecord.

Add a toString() to LogRecord.

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28317

[devoncarew, 2013-09-21 05:08:08]

From svn log, it seems like Siggi is the main reviewer, but I believe he's on
vacation -

https://codereview.chromium.org/24341002/diff/1/pkg/logging/lib/logging.dart
File pkg/logging/lib/logging.dart (right):

https://codereview.chromium.org/24341002/diff/1/pkg/logging/lib/logging.dart#...
pkg/logging/lib/logging.dart:314: String toString() => '[${level.name}]
$loggerName $message';
I actually prefer a slightly different format:

  [foo.bar.baz info] my logging message

but this seems more generally acceptable.

[Siggi Cherem (dart-lang), 2013-10-05 01:09:38]

lgtm

https://codereview.chromium.org/24341002/diff/1/pkg/logging/lib/logging.dart
File pkg/logging/lib/logging.dart (right):

https://codereview.chromium.org/24341002/diff/1/pkg/logging/lib/logging.dart#...
pkg/logging/lib/logging.dart:314: String toString() => '[${level.name}]
$loggerName $message';
On 2013/09/21 05:08:08, devoncarew wrote:
> I actually prefer a slightly different format:
> 
>   [foo.bar.baz info] my logging message
> 
> but this seems more generally acceptable.
> 

I'm ok with either actually. In the current form, consider maybe adding ":"
after the loggerName

[info] foo.bar: my message

[devoncarew, 2013-10-07 18:04:53]

Committed patchset #2 manually as r28317 (presubmit successful).

[devoncarew, 2013-10-07 18:06:27]

https://codereview.chromium.org/24341002/diff/1/pkg/logging/lib/logging.dart
File pkg/logging/lib/logging.dart (right):

https://codereview.chromium.org/24341002/diff/1/pkg/logging/lib/logging.dart#...
pkg/logging/lib/logging.dart:314: String toString() => '[${level.name}]
$loggerName $message';
> [info] foo.bar: my message

OK, changed to add the ':'.

[kevmoo-old, 2013-10-07 19:13:45]

Fixed? https://code.google.com/p/dart/issues/detail?id=13306