Issue 24339002: Escape slash since it helps to end an HTML entity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24339002: Escape slash since it helps to end an HTML entity. (Closed)

Created:
7 years, 3 months ago by nikgraf

Modified:
7 years, 2 months ago

Reviewers:
floitsch, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Escape slash since it helps to end an HTML entity. Escaping a slash is recommended by the OWASP. Replace "'" in HTML escaping by "'" since "'" isn't supported in the HTML4 spec. BUG= http://dartbug.com/13364 R=efortuna@google.com, floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=27945

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	sdk/lib/convert/html_escape.dart	View		2 chunks	+7 lines, -5 lines	0 comments	Download
	M	tests/lib/convert/html_escape_test.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

floitsch

LGTM. thanks. When requesting the initial code-review please Publish+Mail (with an empty body), so that ...

7 years, 2 months ago (2013-09-26 11:36:33 UTC) #2

nikgraf

On 2013/09/26 11:41:26, nikgraf wrote: > Just tried the publish button :) > > Thanks ...

7 years, 2 months ago (2013-09-26 11:44:52 UTC) #4

floitsch

7 years, 2 months ago (2013-09-26 12:19:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r27945 (presubmit successful).