Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 24324005: Updating Shadow DOM and including some fixes to enable it to work with CustomElements. (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updating Shadow DOM and including some fixes to enable it to work with CustomElements. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27785

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -47 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/polymer/test/event_path_test.dart View 1 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/polymer/test/event_path_test.html View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.debug.js View 14 chunks +48 lines, -23 lines 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.min.js View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/shadow_dom/tool/build/if-poly.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
Firefox starts working with these changes, though IE is still broken. TodoMVC looks no more ...
7 years, 2 months ago (2013-09-23 21:39:31 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/24324005/diff/1/pkg/polymer/test/event_path_test.dart File pkg/polymer/test/event_path_test.dart (right): https://codereview.chromium.org/24324005/diff/1/pkg/polymer/test/event_path_test.dart#newcode16 pkg/polymer/test/event_path_test.dart:16: // 'WebComponentsReady' event. any idea if WebComponentsReady works? ...
7 years, 2 months ago (2013-09-23 22:55:20 UTC) #2
blois
https://codereview.chromium.org/24324005/diff/1/pkg/polymer/test/event_path_test.dart File pkg/polymer/test/event_path_test.dart (right): https://codereview.chromium.org/24324005/diff/1/pkg/polymer/test/event_path_test.dart#newcode16 pkg/polymer/test/event_path_test.dart:16: // 'WebComponentsReady' event. On 2013/09/23 22:55:20, John Messerly wrote: ...
7 years, 2 months ago (2013-09-23 23:03:41 UTC) #3
blois
7 years, 2 months ago (2013-09-23 23:04:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698