Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 24323008: Change type of Dart_PersistentHandle to be the same as Dart_Handle so that (Closed)

Created:
7 years, 3 months ago by siva
Modified:
7 years, 2 months ago
Reviewers:
rmacnak, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Change type of Dart_PersistentHandle to be the same as Dart_Handle so that persistent handles can be passed to regular API methods without having to do a Dart_NewHandleFromPersistent first. R=iposva@google.com, rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=28033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/include/dart_api.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 3 months ago (2013-09-23 21:35:26 UTC) #1
Ivan Posva
LGTM -ip
7 years, 3 months ago (2013-09-23 21:53:47 UTC) #2
rmacnak
lgtm
7 years, 3 months ago (2013-09-23 22:41:48 UTC) #3
siva
7 years, 2 months ago (2013-09-28 00:15:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28033 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698