Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 24315008: Make stdin blocking when using Stdin::readByte and readLine. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make stdin blocking when using Stdin::readByte and readLine. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M runtime/bin/stdin_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/stdin_linux.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/stdin_macos.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 3 months ago (2013-09-24 13:18:25 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-24 13:19:00 UTC) #2
Anders Johnsen
7 years, 3 months ago (2013-09-24 13:21:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698