Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 24315002: Reland: Fix bug in field type tracking and polymorphic inlining. (Closed)

Created:
7 years, 3 months ago by Florian Schneider
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reland: Fix bug in field type tracking and polymorphic inlining. Original CL: https://codereview.chromium.org/24096018/ This fixes the bug by changing FlowGraphBuilder to a zone object because it is needed by the inliner later in the pipeline. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=27695

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -49 lines) Patch
M runtime/vm/compiler.cc View 1 4 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 3 chunks +9 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 4 chunks +27 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 2 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 8 chunks +20 lines, -15 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 2 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +1 line, -15 lines 0 comments Download
A + tests/language/vm/optimized_guarded_field_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
7 years, 3 months ago (2013-09-20 09:42:25 UTC) #1
Kevin Millikin (Google)
I like the following approach: 1. Move the guarded_field array into the builder instead of ...
7 years, 3 months ago (2013-09-20 10:19:42 UTC) #2
Kevin Millikin (Google)
This LGTM to get the bug fix in, but we should streamline the whole builder/graph ...
7 years, 3 months ago (2013-09-20 10:27:36 UTC) #3
Florian Schneider
7 years, 3 months ago (2013-09-20 10:35:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r27695 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698