Issue 242983006: Adds load/store from signed unscaled 9-bit offset w/ no writeback.

Issue 242983006: Adds load/store from signed unscaled 9-bit offset w/ no writeback. (Closed)

Created:
6 years, 8 months ago by zra

Modified:
6 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds load/store from signed, unscaled, 9-bit offset w/ no writeback to arm64. I missed this before because it was in the docs under the assembler mnemonic ldur. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35222

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -22 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1 2	2 chunks	+14 lines, -5 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1 2	2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/assembler_arm64_test.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View	1 2	2 chunks	+22 lines, -10 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/242983006/diff/20001/runtime/vm/disassembler_arm64.cc File runtime/vm/disassembler_arm64.cc (right): https://codereview.chromium.org/242983006/diff/20001/runtime/vm/disassembler_arm64.cc#newcode234 runtime/vm/disassembler_arm64.cc:234: case 2: { Should you move this case ...

6 years, 8 months ago (2014-04-21 16:29:10 UTC) #3

zra

https://codereview.chromium.org/242983006/diff/20001/runtime/vm/disassembler_arm64.cc File runtime/vm/disassembler_arm64.cc (right): https://codereview.chromium.org/242983006/diff/20001/runtime/vm/disassembler_arm64.cc#newcode234 runtime/vm/disassembler_arm64.cc:234: case 2: { On 2014/04/21 16:29:11, regis wrote: > ...

6 years, 8 months ago (2014-04-21 20:30:32 UTC) #4

zra

6 years, 8 months ago (2014-04-21 20:30:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r35222 (presubmit successful).

Expand Messages | Collapse Messages