Issue 24272007: Use newline tokens when generating source from tokenstream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24272007: Use newline tokens when generating source from tokenstream. (Closed)

Created:
7 years, 3 months ago by Michael Lippautz (Google)

Modified:
7 years, 3 months ago

Reviewers:
hausner, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use newline tokens when generating source from tokenstream. Line numbers in generated source now match the actual source. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27711

Patch Set 1 : #

Total comments: 2

Patch Set 2 : added comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -19 lines)			Patch
	M	runtime/vm/object.cc	View	1	3 chunks	+43 lines, -17 lines	0 comments	Download
	M	runtime/vm/snapshot_test.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/24272007/diff/3001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/24272007/diff/3001/runtime/vm/object.cc#newcode5748 runtime/vm/object.cc:5748: indent += 2; Please add comment explaining ...

7 years, 3 months ago (2013-09-19 23:42:00 UTC) #2

Michael Lippautz (Google)

https://codereview.chromium.org/24272007/diff/3001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/24272007/diff/3001/runtime/vm/object.cc#newcode5748 runtime/vm/object.cc:5748: indent += 2; On 2013/09/19 23:42:00, Ivan Posva wrote: ...

7 years, 3 months ago (2013-09-20 16:36:25 UTC) #3

Michael Lippautz (Google)

7 years, 3 months ago (2013-09-20 16:36:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27711 (presubmit successful).

Expand Messages | Collapse Messages