Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Issue 24270004: Close stdout and stderr before exiting Pub. (Closed)

Created:
7 years, 3 months ago by nweiz
Modified:
7 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Close stdout and stderr before exiting Pub. This will unblock issue 7218. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=27783

Patch Set 1 #

Patch Set 2 : Import fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -26 lines) Patch
M sdk/lib/_internal/pub/bin/pub.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/cache.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/help.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/lish.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 1 3 chunks +9 lines, -12 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/uploader.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 3 months ago (2013-09-23 19:57:16 UTC) #1
Bob Nystrom
LGTM!
7 years, 3 months ago (2013-09-23 20:10:01 UTC) #2
nweiz
7 years, 3 months ago (2013-09-23 20:38:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27783 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698