Issue 24269017: Fix bugs in SocketAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24269017: Fix bugs in SocketAddress (Closed)

Created:
7 years, 3 months ago by Søren Gjesse

Modified:
7 years, 3 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix bugs in SocketAddress The formatting of IPv6 strings was wrong on Linux and Mac OS - used the IPv4 structure. The fixed socket addresses for any and loopback for IPv6 was mixed up. R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27703

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -14 lines)			Patch
runtime/bin/socket.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
runtime/bin/socket_android.cc	View	1	1 chunk	+12 lines, -4 lines	0 comments	Download
runtime/bin/socket_linux.cc	View		1 chunk	+13 lines, -4 lines	0 comments	Download
runtime/bin/socket_macos.cc	View		1 chunk	+13 lines, -4 lines	0 comments	Download
tests/standalone/io/internet_address_test.dart	View		2 chunks	+13 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Søren Gjesse

Committed patchset #2 manually as r27703 (presubmit successful).

7 years, 3 months ago (2013-09-20 12:47:03 UTC) #3

Message was sent while issue was closed.

Android added.