Issue 24269010: Fix function type parameter parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24269010: Fix function type parameter parsing (Closed)

Created:
7 years, 3 months ago by hausner

Modified:
7 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix function type parameter parsing Corner case of final variables was wrong. In most cases, this went undetected because of the permissive type system of dart. Fixes issue 13367. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=27678

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	runtime/vm/parser.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
	M	tests/language/function_type_parameter_test.dart	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

regis

LGTM but I do not see an update to status files regarding issue 13367 being ...

7 years, 3 months ago (2013-09-19 21:19:38 UTC) #2

hausner

Committed patchset #2 manually as r27678 (presubmit successful).

7 years, 3 months ago (2013-09-19 22:02:50 UTC) #3

hausner

7 years, 3 months ago (2013-09-19 22:04:02 UTC) #4

Message was sent while issue was closed.

We didn't have a test for this particular corner case. The parameter had to be
implicitly final. I added a test case to an existing test.

Thank you.