Emit CSP code in separate file.

Emit CSP code in separate file.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27745

[ahe, 2013-09-19 16:13:10]

Not ready yet, for language test suite in CSP mode, the current status is:

[06:43 | 100% | + 1872 | -   33]

[ahe, 2013-09-20 12:54:44]

Tests are passing now, please review.

[kasperl, 2013-09-20 13:04:47]

LGTM.

https://codereview.chromium.org/24267004/diff/3001/dart/pkg/pkg.status
File dart/pkg/pkg.status (left):

https://codereview.chromium.org/24267004/diff/3001/dart/pkg/pkg.status#oldcod...
dart/pkg/pkg.status:106: observe/test/observe_test: Fail # Issue 11970
Yay!

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart (left):

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart:46:
disallowUnsafeEval: hasOption(options, '--disallow-unsafe-eval'),
Consider warning users that the --disallow-unsafe-eval option is no longer
needed.

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:941: new
jsAst.FunctionDeclaration(
Could you use the convertToFast helper?

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1014:
js.fun([], [js.return_('this[fieldName]')]))
It might be worth investigating how much this costs performance wise. Add a
TODO?

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1832: //
TODO(ahe): Compute a hash code.
Maybe elaborate on the TODO so others would understand what is left to
implement?

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1833:
String name = 'dart_precompiled';
Factor out this constant?

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3829:
function convertToFastObject(properties) {
Could this go through js ASTs?

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3850:
mainBuffer.add(r'''function convertToFastObject(properties) {
Could this go through js ASTs?

https://codereview.chromium.org/24267004/diff/3001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:4129:
mainBuffer.add('$globalObject = convertToFastObject($globalObject)$N');
Could this go through js AST?

https://codereview.chromium.org/24267004/diff/3001/dart/tests/lib/lib.status
File dart/tests/lib/lib.status (left):

https://codereview.chromium.org/24267004/diff/3001/dart/tests/lib/lib.status#...
dart/tests/lib/lib.status:50: mirrors/*: Skip # Issue 6490
Very nice.

[ahe, 2013-09-23 08:19:13]

PTAL at patch set #3.

[ahe, 2013-09-23 09:06:41]

Committed patchset #3 manually as r27745 (presubmit successful).

[kasperl, 2013-09-23 09:34:13]

Still LGTM.

[ngeoffray, 2013-09-24 08:15:29]

DBC

https://codereview.chromium.org/24267004/diff/9014/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/24267004/diff/9014/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:862:
jsAst.Fun get finishIsolateConstructorFunction_NO_CSP {
Is that dead code?

https://codereview.chromium.org/24267004/diff/9014/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3830:
void emitConvertToFastObjectFunction_NO_CSP() {
Ditto

[ahe, 2013-09-24 14:05:09]

Thank you!

https://codereview.chromium.org/24267004/diff/9014/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/24267004/diff/9014/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:862:
jsAst.Fun get finishIsolateConstructorFunction_NO_CSP {
On 2013/09/24 08:15:29, ngeoffray wrote:
> Is that dead code?

Yes, removed in https://codereview.chromium.org/24331012/.