Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 24267002: Emit compile-time error on 'const' formal parameters. (Closed)

Created:
7 years, 3 months ago by karlklose
Modified:
7 years, 3 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Emit compile-time error on 'const' formal parameters. R=ngeoffray@google.com BUG=dartlang.com/5519 Committed: https://code.google.com/p/dart/source/detail?r=27650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 2 chunks +0 lines, -7 lines 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 3 months ago (2013-09-19 09:19:25 UTC) #1
ngeoffray
LGTM
7 years, 3 months ago (2013-09-19 09:24:01 UTC) #2
karlklose
7 years, 3 months ago (2013-09-19 09:29:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27650 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698