- Write the coverage data to a file instead of printing to stdout.

- Write the coverage data to a file instead of printing to stdout.
- Explicitly include lines with zero hits.

[siva, 2013-09-20 19:51:45]

lgtm

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc
File runtime/vm/coverage.cc (right):

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc#newcode7
runtime/vm/coverage.cc:7: #include "include/dart_api.h"
Most of our files seem to have a blank line between
#include "include...." variety and
#include "vm..." variety

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc#newcod...
runtime/vm/coverage.cc:118: char* filename =
Isolate::Current()->current_zone()->Alloc<char>(len + 1);;
double semi colon

https://codereview.chromium.org/24255013/diff/1/runtime/vm/json_stream.h
File runtime/vm/json_stream.h (right):

https://codereview.chromium.org/24255013/diff/1/runtime/vm/json_stream.h#newc...
runtime/vm/json_stream.h:22: TextBuffer* buffer() { return &buffer_; }
TextBuffer* buffer() const { return &buffer_; }

https://codereview.chromium.org/24255013/diff/1/runtime/vm/json_stream.h#newc...
runtime/vm/json_stream.h:23: const char* ToCString() { return buffer_.buf(); }
Ditto here.

[Michael Lippautz (Google), 2013-09-20 21:24:55]

lgtm

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc
File runtime/vm/coverage.cc (right):

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc#newcode37
runtime/vm/coverage.cc:37: jsobj.AddProperty("function", name.ToCString());
Any reason for keeping the function name? Thought we would get rid of it.

[Ivan Posva, 2013-09-20 21:37:07]

Thanks!

-Ivan

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc
File runtime/vm/coverage.cc (right):

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc#newcode7
runtime/vm/coverage.cc:7: #include "include/dart_api.h"
On 2013/09/20 19:51:45, siva wrote:
> Most of our files seem to have a blank line between
> #include "include...." variety and
> #include "vm..." variety

Done.

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc#newcode37
runtime/vm/coverage.cc:37: jsobj.AddProperty("function", name.ToCString());
On 2013/09/20 21:24:56, Michael Lippautz wrote:
> Any reason for keeping the function name? Thought we would get rid of it.

Redoing the coverage data file will come in a different CL. One thing at a
time...

https://codereview.chromium.org/24255013/diff/1/runtime/vm/coverage.cc#newcod...
runtime/vm/coverage.cc:118: char* filename =
Isolate::Current()->current_zone()->Alloc<char>(len + 1);;
On 2013/09/20 19:51:45, siva wrote:
> double semi colon

Done.

https://codereview.chromium.org/24255013/diff/1/runtime/vm/json_stream.h
File runtime/vm/json_stream.h (right):

https://codereview.chromium.org/24255013/diff/1/runtime/vm/json_stream.h#newc...
runtime/vm/json_stream.h:22: TextBuffer* buffer() { return &buffer_; }
On 2013/09/20 19:51:45, siva wrote:
> TextBuffer* buffer() const { return &buffer_; }

Unfortunately that is not possible because the embedded buffer_ object is not
constant.

https://codereview.chromium.org/24255013/diff/1/runtime/vm/json_stream.h#newc...
runtime/vm/json_stream.h:23: const char* ToCString() { return buffer_.buf(); }
On 2013/09/20 19:51:45, siva wrote:
> Ditto here.

Ditto here.

[siva, 2013-10-28 02:01:22]

I presume this CL has been submitted, can it be closed?