Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24251016: Revert "Dart2js support for custom element lifecycle events" (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Dart2js support for custom element lifecycle events" This reverts commit 27729. Shadow DOM polyfill appears to have regressed some tests and some issues are coming up with the browser controller. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -512 lines) Patch
M pkg/custom_element/lib/custom-elements.debug.js View 7 chunks +100 lines, -71 lines 0 comments Download
M pkg/custom_element/lib/custom-elements.min.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.debug.js View 14 chunks +22 lines, -47 lines 0 comments Download
M pkg/shadow_dom/lib/shadow_dom.min.js View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill.js View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/shadow_dom/tool/build/if-poly.js View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +5 lines, -35 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M tests/html/custom/constructor_calls_created_synchronously_test.dart View 2 chunks +12 lines, -1 line 0 comments Download
M tests/html/custom/created_callback_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/html/custom/document_register_basic_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/html/custom/document_register_type_extensions_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
D tests/html/custom/entered_left_view_test.dart View 1 chunk +0 lines, -246 lines 0 comments Download
D tests/html/custom/entered_left_view_test.html View 1 chunk +0 lines, -23 lines 0 comments Download
M tests/html/html.status View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/html/utils.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 2 chunks +5 lines, -21 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 3 months ago (2013-09-21 00:44:00 UTC) #1
Jennifer Messerly
sigh :( lgtm
7 years, 3 months ago (2013-09-21 00:45:44 UTC) #2
blois
7 years, 3 months ago (2013-09-21 00:53:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r27730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698