Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 242453011: Add class id to debugger stack trace (Closed)

Created:
6 years, 8 months ago by hausner
Modified:
6 years, 8 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add class id to debugger stack trace Add the class id of the origin class of each activation frame’s function. Top-level functions have no class id. The wire protocol for an activation frame now looks like this: CallFrame = “{“ functionName “:” String “,” [ location “:” Location “,” ] [ classId “:” Integer “,” ] locals “:” NamedObjList “}“ R=devoncarew@google.com Committed: https://code.google.com/p/dart/source/detail?r=35232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M runtime/bin/dbg_message.cc View 2 chunks +9 lines, -1 line 0 comments Download
M runtime/include/dart_debugger_api.h View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
Let me know if this change works for you.
6 years, 8 months ago (2014-04-21 21:35:54 UTC) #1
devoncarew
lgtm Yup, this will work - thanks.
6 years, 8 months ago (2014-04-21 21:53:30 UTC) #2
hausner
6 years, 8 months ago (2014-04-21 23:16:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35232 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698