Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 24240010: Implement symbol literals in the VM compiler (Closed)

Created:
7 years, 3 months ago by hausner
Modified:
7 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Implement symbol literals in the VM compiler Issue 12171 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27668

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -168 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +15 lines, -15 lines 0 comments Download
M runtime/vm/intermediate_language.h View 4 chunks +61 lines, -61 lines 0 comments Download
M runtime/vm/intrinsifier.h View 2 chunks +78 lines, -78 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 chunks +46 lines, -0 lines 0 comments Download
M runtime/vm/scanner.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M runtime/vm/symbols.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/token.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 3 months ago (2013-09-19 16:15:37 UTC) #1
Ivan Posva
LGTM -ip
7 years, 3 months ago (2013-09-19 17:38:21 UTC) #2
hausner
7 years, 3 months ago (2013-09-19 17:39:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27668 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698