pkg/docgen: moved model classes into minilibs

pkg/docgen: moved model classes into minilibs

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35187

[kevmoo, 2014-04-18 17:03:18]

This is just moving around. In a few cases I had to make private things public.

https://codereview.chromium.org/242363004/diff/1/pkg/docgen/lib/src/mdn.dart
File pkg/docgen/lib/src/mdn.dart (right):

https://codereview.chromium.org/242363004/diff/1/pkg/docgen/lib/src/mdn.dart#...
pkg/docgen/lib/src/mdn.dart:20: //Check if MDN is loaded.
Just whitespace cleanup

https://codereview.chromium.org/242363004/diff/1/pkg/docgen/lib/src/models/cl...
File pkg/docgen/lib/src/models/class.dart (right):

https://codereview.chromium.org/242363004/diff/1/pkg/docgen/lib/src/models/cl...
pkg/docgen/lib/src/models/class.dart:1: library docgen.models.class_indexable;
Analyzer does not like a library sub-unit named 'class'

[Siggi Cherem (dart-lang), 2014-04-18 22:20:07]

overall lgtm, but I'm not very familiar with this code base. I personally don't
mind a big file with all the models, but the new way seems OK to me too.

https://codereview.chromium.org/242363004/diff/1/pkg/docgen/lib/src/models/cl...
File pkg/docgen/lib/src/models/class.dart (right):

https://codereview.chromium.org/242363004/diff/1/pkg/docgen/lib/src/models/cl...
pkg/docgen/lib/src/models/class.dart:1: library docgen.models.class_indexable;
On 2014/04/18 17:03:18, kevmoo wrote:
> Analyzer does not like a library sub-unit named 'class'

The name class_indexable is a bit strange. Some other ideas (based on how
typically we'd replace the 'class' keyword in code):
- docgen.models.class_
- docgen.models.clazz
- docgen.models.cls

https://codereview.chromium.org/242363004/diff/20001/pkg/docgen/lib/src/model...
File pkg/docgen/lib/src/models/doc_gen_type.dart (right):

https://codereview.chromium.org/242363004/diff/20001/pkg/docgen/lib/src/model...
pkg/docgen/lib/src/models/doc_gen_type.dart:62: return
mirror.typeArguments.map((e) => new DocGenType(e, owningLibrary)).toList();
long line (might have been from before?)

[kevmoo, 2014-04-18 22:36:43]

https://codereview.chromium.org/242363004/diff/1/pkg/docgen/lib/src/models/cl...
File pkg/docgen/lib/src/models/class.dart (right):

https://codereview.chromium.org/242363004/diff/1/pkg/docgen/lib/src/models/cl...
pkg/docgen/lib/src/models/class.dart:1: library docgen.models.class_indexable;
On 2014/04/18 22:20:08, Siggi Cherem (dart-lang) wrote:
> On 2014/04/18 17:03:18, kevmoo wrote:
> > Analyzer does not like a library sub-unit named 'class'
> 
> The name class_indexable is a bit strange. Some other ideas (based on how
> typically we'd replace the 'class' keyword in code):
> - docgen.models.class_
> - docgen.models.clazz
> - docgen.models.cls

Done.

https://codereview.chromium.org/242363004/diff/20001/pkg/docgen/lib/src/model...
File pkg/docgen/lib/src/models/doc_gen_type.dart (right):

https://codereview.chromium.org/242363004/diff/20001/pkg/docgen/lib/src/model...
pkg/docgen/lib/src/models/doc_gen_type.dart:62: return
mirror.typeArguments.map((e) => new DocGenType(e, owningLibrary)).toList();
On 2014/04/18 22:20:08, Siggi Cherem (dart-lang) wrote:
> long line (might have been from before?)

Done.

[kevmoo, 2014-04-18 22:37:17]

Committed patchset #3 manually as r35187 (presubmit successful).

[Emily Fortuna, 2014-04-21 16:41:08]

this is starting to get a bit java-y with a bazillion files, one for each class.

https://codereview.chromium.org/242363004/diff/30001/pkg/docgen/lib/src/gener...
File pkg/docgen/lib/src/generator.dart (right):

https://codereview.chromium.org/242363004/diff/30001/pkg/docgen/lib/src/gener...
pkg/docgen/lib/src/generator.dart:235: ..writeAll(sortedEntities, '\n')
nope only two spaces for the ..

[kevmoo, 2014-04-21 16:45:42]

On 2014/04/21 16:41:08, Emily Fortuna wrote:
> this is starting to get a bit java-y with a bazillion files, one for each
class.

It ends up being really useful to track dependencies. I'm not going to go any
further here. :-)

>
https://codereview.chromium.org/242363004/diff/30001/pkg/docgen/lib/src/gener...
> File pkg/docgen/lib/src/generator.dart (right):
> 
>
https://codereview.chromium.org/242363004/diff/30001/pkg/docgen/lib/src/gener...
> pkg/docgen/lib/src/generator.dart:235: ..writeAll(sortedEntities, '\n')
> nope only two spaces for the ..

Our formatter tools are doing 4 spaces for '..' - perhaps we have some confusion

[Emily Fortuna, 2014-04-21 17:28:26]

https://codereview.chromium.org/242363004/diff/30001/pkg/docgen/lib/src/gener...
File pkg/docgen/lib/src/generator.dart (right):

https://codereview.chromium.org/242363004/diff/30001/pkg/docgen/lib/src/gener...
pkg/docgen/lib/src/generator.dart:235: ..writeAll(sortedEntities, '\n')
On 2014/04/21 16:41:08, Emily Fortuna wrote:
> nope only two spaces for the ..

huh looks like the style guide was updated. Sheesh! Keeps changing on me! I gave
the reverse advice to devrel folk and they told me it was this way.