Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 24211003: Let the inferrer know that lazy variables can also be null incase their initializer throws. (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
karlklose, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Let the inferrer know that lazy variables can also be null incase their initializer throws. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=27664

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/type_graph_inferrer.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/throwing_lazy_variable_test.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-19 14:00:04 UTC) #1
karlklose
LGTM.
7 years, 3 months ago (2013-09-19 14:07:21 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-19 15:41:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698