Issue 24208007: Do not make the test depend on one specific exception, so that it can pass on dart2js and VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24208007: Do not make the test depend on one specific exception, so that it can pass on dart2js and VM. (Closed)

Created:
7 years, 3 months ago by ngeoffray

Modified:
7 years, 2 months ago

Reviewers:
karlklose, srdjan

CC:
reviews_dartlang.org, floitsch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Do not make the test depend on one specific exception, so that it can pass on dart2js and VM. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=27741

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	tests/language/div_with_power_of_two_test.dart	View		1 chunk	+3 lines, -4 lines	0 comments	Download
	M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

ngeoffray

Committed patchset #2 manually as r27741 (presubmit successful).

7 years, 3 months ago (2013-09-23 08:16:42 UTC) #3

srdjan

Shouldn't the exception thrown by division-by-zero be exactly specified?

7 years, 2 months ago (2013-09-25 16:25:17 UTC) #4

Message was sent while issue was closed.

lgtm