Support typeVariables in ClassMirror.

Support typeVariables in ClassMirror.

R=ahe@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27753

[ahe, 2013-09-23 08:17:03]

LGTM!

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:182: 
Remove extra line.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1271: var upperBound =
Please add a type.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1274: var typeMirror =
Weird indentation.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1276: result.add(typeMirror);
Weird indentation.

[ahe, 2013-09-23 08:17:57]

What about tests/lib/mirrors/mirrors_test.dart? It should be pretty close to
working by now.

[karlklose, 2013-09-23 08:50:34]

LGTM.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2020: var
superclass = classElement.superclass;
Please add a type annotation.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2021: if
((!typeVars.isEmpty && superclass == null)
You could save the result of this check in a local to make the tests shorter.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2023: &&
superclass.typeVariables != classElement.typeVariables)) {
Consider storing classElement.typeVariables in a local and shere it with line
2015. Perhaps that would allow to write this boolean expression in one line.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2024:
builder.addProperty('<>', new jsAst.ArrayInitializer.from(typeVars));
We should move the '<>' into the namer (not this CL).

[zarah, 2013-09-23 11:17:02]

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2020: var
superclass = classElement.superclass;
On 2013/09/23 08:50:34, karlklose wrote:
> Please add a type annotation.

Done.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2021: if
((!typeVars.isEmpty && superclass == null)
On 2013/09/23 08:50:34, karlklose wrote:
> You could save the result of this check in a local to make the tests shorter.

Done.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2023: &&
superclass.typeVariables != classElement.typeVariables)) {
On 2013/09/23 08:50:34, karlklose wrote:
> Consider storing classElement.typeVariables in a local and shere it with line
> 2015. Perhaps that would allow to write this boolean expression in one line.

Done.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2024:
builder.addProperty('<>', new jsAst.ArrayInitializer.from(typeVars));
On 2013/09/23 08:50:34, karlklose wrote:
> We should move the '<>' into the namer (not this CL).

OK.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:182: 
On 2013/09/23 08:17:03, ahe wrote:
> Remove extra line.

Done.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1271: var upperBound =
On 2013/09/23 08:17:03, ahe wrote:
> Please add a type.

Done.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1274: var typeMirror =
On 2013/09/23 08:17:03, ahe wrote:
> Weird indentation.

Done.

https://codereview.chromium.org/24197003/diff/5001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1276: result.add(typeMirror);
On 2013/09/23 08:17:03, ahe wrote:
> Weird indentation.

Done.

[zarah, 2013-09-23 11:18:05]

Committed patchset #2 manually as r27753 (presubmit successful).