Issue 24195007: Fix polymer_expressions syntax test on Safari and IE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24195007: Fix polymer_expressions syntax test on Safari and IE (Closed)

Created:
7 years, 3 months ago by justinfagnani

Modified:
7 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix polymer_expressions syntax test on Safari and IE BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27630

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	pkg/polymer_expressions/test/syntax_test.dart	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/24195007/diff/1/pkg/polymer_expressions/test/syntax_test.dart File pkg/polymer_expressions/test/syntax_test.dart (right): https://codereview.chromium.org/24195007/diff/1/pkg/polymer_expressions/test/syntax_test.dart#newcode26 pkg/polymer_expressions/test/syntax_test.dart:26: testDiv.nodes[0].remove(); firstChild?

7 years, 3 months ago (2013-09-18 07:30:06 UTC) #2

justinfagnani

https://chromiumcodereview.appspot.com/24195007/diff/1/pkg/polymer_expressions/test/syntax_test.dart File pkg/polymer_expressions/test/syntax_test.dart (right): https://chromiumcodereview.appspot.com/24195007/diff/1/pkg/polymer_expressions/test/syntax_test.dart#newcode26 pkg/polymer_expressions/test/syntax_test.dart:26: testDiv.nodes[0].remove(); On 2013/09/18 07:30:06, John Messerly wrote: > firstChild? ...

7 years, 3 months ago (2013-09-18 17:24:15 UTC) #3

justinfagnani

7 years, 3 months ago (2013-09-18 17:25:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r27630 (presubmit successful).

Expand Messages | Collapse Messages