Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2418763002: Update Set.difference to take a Set<Object>. (Closed)

Created:
4 years, 2 months ago by floitsch
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org, kevmoo, vsm, nweiz
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update changelog and version number. #

Patch Set 3 : Update dependency on SDK to 1.21. #

Total comments: 3

Patch Set 4 : Updated version number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/typed_wrappers.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/wrappers.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
floitsch
See https://codereview.chromium.org/2413233002/ for the corresponding core change.
4 years, 2 months ago (2016-10-13 09:46:10 UTC) #2
Lasse Reichstein Nielsen
lgtm Update CHANGELOG.md and version in pubspec.yaml.
4 years, 2 months ago (2016-10-13 11:34:29 UTC) #3
floitsch
done.
4 years, 2 months ago (2016-10-13 14:32:33 UTC) #4
kevmoo
Hold on a sec – this will be strong mode broken until the associated SDK ...
4 years, 2 months ago (2016-10-13 16:05:18 UTC) #6
Lasse Reichstein Nielsen
I think this should qualify for a minor version update on the version number. To ...
4 years, 2 months ago (2016-10-13 16:28:18 UTC) #7
floitsch
Updated sdk dependency.
4 years, 2 months ago (2016-10-14 09:32:33 UTC) #8
Lasse Reichstein Nielsen
https://codereview.chromium.org/2418763002/diff/40001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2418763002/diff/40001/pubspec.yaml#newcode2 pubspec.yaml:2: version: 1.9.2 Make this 1.10.0
4 years, 2 months ago (2016-10-14 09:37:22 UTC) #9
nweiz
https://codereview.chromium.org/2418763002/diff/40001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2418763002/diff/40001/pubspec.yaml#newcode2 pubspec.yaml:2: version: 1.9.2 On 2016/10/14 09:37:22, Lasse Reichstein Nielsen wrote: ...
4 years, 2 months ago (2016-10-14 19:34:51 UTC) #11
Lasse Reichstein Nielsen
On 2016/10/14 19:34:51, nweiz wrote: > https://codereview.chromium.org/2418763002/diff/40001/pubspec.yaml > File pubspec.yaml (right): > > https://codereview.chromium.org/2418763002/diff/40001/pubspec.yaml#newcode2 > ...
4 years, 2 months ago (2016-10-17 08:20:26 UTC) #12
floitsch
https://codereview.chromium.org/2418763002/diff/40001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/2418763002/diff/40001/pubspec.yaml#newcode2 pubspec.yaml:2: version: 1.9.2 On 2016/10/14 19:34:51, nweiz wrote: > On ...
4 years, 2 months ago (2016-10-17 13:13:58 UTC) #13
floitsch
4 years, 2 months ago (2016-10-20 12:37:41 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
ce47804d77a060ca13cd708c279ec45007ff83f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698