Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 241823002: Change UNDEFINED_FUNCTION from an error to a warning (issues 18274, 15315). (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Change UNDEFINED_FUNCTION from an error to a warning (issues 18274, 15315). Also update the spec quote for the error enum, and add a unit test for a case that wasn't previously covered (test_undefinedFunction_inImportedLib). R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=35163

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
Paul Berry
Note that this partially un-does https://code.google.com/p/dart/source/detail?r=26016. It looks like the spec has changed and this ...
6 years, 8 months ago (2014-04-17 22:07:06 UTC) #1
Brian Wilkerson
LGTM
6 years, 8 months ago (2014-04-18 01:32:50 UTC) #2
scheglov
LGTM
6 years, 8 months ago (2014-04-18 02:11:00 UTC) #3
Paul Berry
6 years, 8 months ago (2014-04-18 13:44:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r35163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698