Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 24180004: Source selection API abstraction first cut. (Closed)

Created:
7 years, 3 months ago by pquitslund
Modified:
7 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Source selection API abstraction first cut. No implementation yet just a rough of how the API might look. Note that how clients pass selection information into main (and get it back) is still TBD. Comments welcome! R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=27586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M pkg/analyzer_experimental/bin/formatter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 3 chunks +31 lines, -5 lines 0 comments Download
M pkg/analyzer_experimental/test/services/formatter_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
7 years, 3 months ago (2013-09-16 23:21:21 UTC) #1
Brian Wilkerson
LGTM
7 years, 3 months ago (2013-09-17 07:01:13 UTC) #2
pquitslund
7 years, 3 months ago (2013-09-17 23:26:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698