Prevent unbounded growth of the getField/setField closure caches.

Prevent unbounded growth of the getField/setField closure caches.

BUG=http://dartbug.com/16539
R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35433

[rmacnak, 2014-04-18 17:23:41]

Also bound the call counts at 2x the factor for the closures.

[Ivan Posva, 2014-04-25 17:07:08]

LGTMwC

-Ivan

https://codereview.chromium.org/241703002/diff/40001/runtime/lib/mirrors_impl...
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/241703002/diff/40001/runtime/lib/mirrors_impl...
runtime/lib/mirrors_impl.dart:338: if (_getFieldCallCounts.length == 2 *
_cacheSizeLimit) {
Please file a bug that we need to implement a LRU cache helper class for use in
the internal VM libraries.

https://codereview.chromium.org/241703002/diff/40001/tests/lib/mirrors/access...
File tests/lib/mirrors/accessor_cache_overflow_test.dart (right):

https://codereview.chromium.org/241703002/diff/40001/tests/lib/mirrors/access...
tests/lib/mirrors/accessor_cache_overflow_test.dart:5: library
test.hot_get_field;
Please explain the purpose of this test in a comment.

https://codereview.chromium.org/241703002/diff/40001/tests/lib/mirrors/access...
tests/lib/mirrors/accessor_cache_overflow_test.dart:13: var digits =
['0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F'];
long line

[rmacnak, 2014-04-25 17:46:22]

https://codereview.chromium.org/241703002/diff/40001/runtime/lib/mirrors_impl...
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/241703002/diff/40001/runtime/lib/mirrors_impl...
runtime/lib/mirrors_impl.dart:338: if (_getFieldCallCounts.length == 2 *
_cacheSizeLimit) {
On 2014/04/25 17:07:08, Ivan Posva wrote:
> Please file a bug that we need to implement a LRU cache helper class for use
in
> the internal VM libraries.

Done.

https://codereview.chromium.org/241703002/diff/40001/tests/lib/mirrors/access...
File tests/lib/mirrors/accessor_cache_overflow_test.dart (right):

https://codereview.chromium.org/241703002/diff/40001/tests/lib/mirrors/access...
tests/lib/mirrors/accessor_cache_overflow_test.dart:5: library
test.hot_get_field;
On 2014/04/25 17:07:08, Ivan Posva wrote:
> Please explain the purpose of this test in a comment.

Done.

[rmacnak, 2014-04-25 17:47:19]

Committed patchset #4 manually as r35433 (presubmit successful).